Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add GPU version of contrib.boolean_mask #14090

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Add GPU version of contrib.boolean_mask #14090

merged 1 commit into from
Feb 15, 2019
+313 −72

Conversation

HyperZealot
Copy link
Contributor

@HyperZealot HyperZealot commented Feb 8, 2019 •
edited
Loading

Description

The same as title

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • With additional parallelization of CPU version

junrushao
junrushao approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao
Copy link
Member

Please fix the CI issues :-)

@zheng-da
Copy link
Contributor

zheng-da commented Feb 8, 2019

great work! thanks

zheng-da
zheng-da reviewed Feb 8, 2019
View reviewed changes
src/operator/contrib/boolean_mask.cu
prefix_sum,
prefix_sum,
idx_size,
Stream<gpu>::GetStream(s));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add comments to explain the purpose of the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please check.

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review, Operator]

@marcoabreu marcoabreu added Operator pr-awaiting-review PR is waiting for code review labels Feb 8, 2019
@HyperZealot HyperZealot force-pushed the boolean_mask_gpu branch 2 times, most recently from dcaee54 to ba65b42 Compare February 9, 2019 20:33
zheng-da
zheng-da reviewed Feb 12, 2019
View reviewed changes
src/operator/contrib/boolean_mask.cc Outdated
const std::vector<OpReqType> &req,
const std::vector<NDArray> &outputs) {
// TODO(@junrushao1994): This implementation is a proof-of-concept,
// hence very slow actually. Performance should be improved in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the comment here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

zheng-da
zheng-da approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@zheng-da zheng-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the old comments. otherwise, it looks good to me.

@HyperZealot
Copy link
Contributor Author

@zheng-da Should be good for merge once build passes

@junrushao
Copy link
Member

Looks like there are some issues with the CI. Could you try again?

@HyperZealot HyperZealot force-pushed the boolean_mask_gpu branch 2 times, most recently from 2ef0507 to 3051c7c Compare February 14, 2019 21:44
@zheng-da zheng-da merged commit ba97fb6 into apache:master Feb 15, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@HyperZealot @stephenrawls
Parallelize CPU version and add GPU version of boolean_mask op (apach…
6ed5c69 
…e#14090)
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
@HyperZealot
Parallelize CPU version and add GPU version of boolean_mask op (apach…
a92f251 
…e#14090)
@szha szha mentioned this pull request Feb 19, 2019
Closed
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
@HyperZealot @drivanov
Parallelize CPU version and add GPU version of boolean_mask op (apach…
e6124b5 
…e#14090)
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@HyperZealot @vdantu
Parallelize CPU version and add GPU version of boolean_mask op (apach…
330cada 
…e#14090)
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@HyperZealot
Parallelize CPU version and add GPU version of boolean_mask op (apach…
a6ded28 
…e#14090)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@junrushao junrushao junrushao approved these changes

@zheng-da zheng-da zheng-da approved these changes

Assignees
No one assigned
Labels
Operator pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HyperZealot @junrushao @zheng-da @vandanavk @marcoabreu